Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent_integration.md #23104

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update agent_integration.md #23104

wants to merge 4 commits into from

Conversation

emarsha94
Copy link
Contributor

to add how to install wheels on container env

What does this PR do? What is the motivation?

to add how to install wheels on container env

Merge instructions

  • Please merge after reviewing

Additional notes

to add how to install wheels on container env
@emarsha94 emarsha94 requested review from a team as code owners May 9, 2024 22:22
@emarsha94 emarsha94 requested a review from a team May 9, 2024 22:33
@hestonhoffman hestonhoffman added the editorial review Waiting on a more in-depth review label May 9, 2024
Co-authored-by: emarsha94 <52013262+emarsha94@users.noreply.github.com>
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @emarsha94, sorry this took so long to review. I left some small edits just for consistency. I'd like to circle back later with a follow-up PR to give some example commands.

@@ -436,6 +436,12 @@ sudo datadog-agent integration install -w /path/to/wheel.whl
```
</details>

For installing your wheel to test in Kubernetes environments:
1. Mount the whl into a initContainer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Mount the whl into a initContainer
1. Mount the `.whl` file into an initContainer.

@@ -436,6 +436,12 @@ sudo datadog-agent integration install -w /path/to/wheel.whl
```
</details>

For installing your wheel to test in Kubernetes environments:
1. Mount the whl into a initContainer
2. Run the whl install in the init container
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Run the whl install in the init container
2. Run the wheel install in the initContainer.

For installing your wheel to test in Kubernetes environments:
1. Mount the whl into a initContainer
2. Run the whl install in the init container
3. Mount the init container in the agent container while it's running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Mount the init container in the agent container while it's running
3. Mount the initContainer in the Agent container while it's running.

2. Run the whl install in the init container
3. Mount the init container in the agent container while it's running

For customer install commands for both host and container environments, please see [here.][35]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For customer install commands for both host and container environments, please see [here.][35]
For customer install commands for both host and container environments, see the [Community and Marketplace Integrations documentation][35].

@hestonhoffman hestonhoffman self-assigned this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants